MRG, FIX: Fix for singleton and efficiency #7469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7469 +/- ##
==========================================
- Coverage 90.08% 90.08% -0.01%
==========================================
Files 454 454
Lines 82562 82539 -23
Branches 13351 13051 -300
==========================================
- Hits 74375 74353 -22
- Misses 5348 5360 +12
+ Partials 2839 2826 -13 |
|
thx @larsoner |
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to recover some commits from the rolled-back #7257. In theory this should fix CircleCI in
master. Tests pass locally, let's see if the CIs agree. This refactors_brainto make several improvements:smoothing_matrixis only used in one place@GuillaumeFavelier if things are green I think we should merge this, then maybe bring back the rest of #7257 ?