Add support --perf-basic-prof #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What would it take to get this merged? |
|
Thanks for the PR! Maybe add it to |
robraux
force-pushed
the
perf-basic-prof
branch
from
4ea29ec
to
c51119b
Compare
|
@danielstjules - updated to take into account |
|
@danielstjules anything else I can do to facilitate a merge here. I couldn't find anymore information on places to follow up re:mocha. |
|
Sorry for the delay! Thanks again! |
danielstjules
added a commit
that referenced
this pull request
Dec 25, 2015
Add support --perf-basic-prof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic PR, adding support for --perf-basic-prof v8 option.
This supports creating flamegraphs on linux with mocha tests.