Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix this.skip from spec with HTML reporter #2048

Merged
merged 1 commit into from
Jan 11, 2016

Conversation

danielstjules
Copy link
Contributor

From #1945 (comment) Fixes the following simple case for the HTML reporter:

describe('skipping', function() {
  it('amazes', function() {
    this.skip()
    assert(true)
  })
})

// expected: "amazes" test shows as pending within test results
// actual outcome: "TypeError: Cannot read property 'toString' of undefined"

Before PR:

screen shot 2016-01-11 at 5 12 24 am

After PR:

screen shot 2016-01-11 at 5 11 59 am

Review on Reviewable

@danielstjules danielstjules changed the title Fix #1760: Enable this.skip() within individual test at runtime Fix this.skip from spec with HTML reporter Jan 11, 2016
danielstjules added a commit that referenced this pull request Jan 11, 2016
Fix `this.skip` from spec with HTML reporter
@danielstjules danielstjules merged commit cbc3952 into mochajs:master Jan 11, 2016
@mislav mislav deleted the fix-skip branch January 23, 2016 03:35
@mislav
Copy link
Contributor

mislav commented Jan 23, 2016

Thanks @danielstjules!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants