Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2071: Removed color code to fix Chalk colors #2072

Merged
merged 1 commit into from
Jan 26, 2016
Merged

Fix #2071: Removed color code to fix Chalk colors #2072

merged 1 commit into from
Jan 26, 2016

Conversation

thedark1337
Copy link
Contributor

Removed extraneous color code that broke output on Windows as shown in #2071

Review on Reviewable

@danielstjules
Copy link
Contributor

I wonder if chalk handles \u001b[0m for us, making resetting to the normal color unnecessary. But I guess given our lack of test coverage around this, it's best to keep the changeset small.

@thedark1337
Copy link
Contributor Author

From reading the source code of what Chalk uses , it appears to reset already for the open / close. Testing with my mocha tests for my ESLInt config, it seems that is true. Should I remove it as well and amend the commit?

@danielstjules
Copy link
Contributor

Sure, I'll just wanna test with a bunch of reporters prior to giving a thumbs up

@jbnicolai
Copy link

From reading the source code of what Chalk uses , it appears to reset already for the open / close

Yeah, having worked on Chalk, I can definitely confirm that is the case. Both the opening and closing escape can be removed.

Should I remove it as well and amend the commit?

Yes please :)

Sure, I'll just wanna test with a bunch of reporters prior to giving a thumbs up
Show all checks

Absolutely! Although I can confidently say that there's no need to do any extra escaping/wrapping around Chalk.

@thedark1337
Copy link
Contributor Author

Amended the commit to remove the reset code. 👍

@boneskull
Copy link
Contributor

@thedark1337 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants