Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to prevent ReDoS for clean() #4917

Closed
wants to merge 1 commit into from

Conversation

outsideris
Copy link
Contributor

Description of the Change

In #4770 , ReDoS vulnerabilities of the regex fixed. So, this test to prevent regression ReDoS.

@outsideris outsideris added the qa label Aug 25, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.326% when pulling 8a37975 on outsideris:clean-redos-test into 41567df on mochajs:master.

Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris
Copy link
Contributor Author

I will merge this in a few days.

@juergba
Copy link
Contributor

juergba commented Nov 24, 2022

@outsideris Imo this test has no benefit.

@outsideris
Copy link
Contributor Author

I think this test prevent regression ReDoS because when we fix the RegExp, it is hard to ReDoS vulnerability.
If you think like that I will close this.

@outsideris outsideris closed this Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants