Remove deprecated verifyZeroInteractions #447
Conversation
|
@TimvdLippe I bumped mockito-kotlin/tests/build.gradle Line 25 in 37bbae4 |
|
@rashadsookram Oh that's strange. Yes we should update the version in both. They should have been using the same version from the get-go. Maybe we can remove that line from the test gradle file altogether, as it will use the artifact inherited from the main bundle? |
... to 4.0.0. Fixes mockito#446.
| verify(out).println("methods.stringResult();") | ||
| argumentCaptor<DescribedInvocation>().apply { | ||
| verify(out).println(capture()) | ||
| expect(lastValue.toString()).toBe("methods.stringResult();") | ||
| } |
There was a problem hiding this comment.
In Mockito 2.23.0, println used to be called with a string, but in 4.0.0 it's called with a DescribedInvocation directly.
What do you think about checking the value like this? It didn't seem like it would be simple to create an InterceptedInvocation to use for the test.
There was a problem hiding this comment.
Yeah that seems good to me 👍
|
@TimvdLippe I updated the version in the An alternative would be to make something like the |
| verify(out).println("methods.stringResult();") | ||
| argumentCaptor<DescribedInvocation>().apply { | ||
| verify(out).println(capture()) | ||
| expect(lastValue.toString()).toBe("methods.stringResult();") | ||
| } |
There was a problem hiding this comment.
Yeah that seems good to me 👍
|
When can we expect a release of mockito-kotlin, which is compatible with Mockito 4? |
|
@ratepay-sstein I had pushed the 4.0.0 tag yesterday, but it seems like it wasn't running the release procedure. #448 should fix that, thanks for letting us know! |
|
4.0.0 is now available at https://repo1.maven.org/maven2/org/mockito/kotlin/mockito-kotlin/4.0.0/ |
|
@TimvdLippe Wow, that was fast :-) I haven't migrated our full source yet, but it seems to work. |
Fixes #446.
I just removed the method for now, but if it's preferred to keep it around and call through to
verifyNoMoreInteractionsinstead, let me know and I can update the PR.Thank you for submitting a pull request! But first:
verifyZeroInteractionsas far as I can tell