Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #504

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Update PR template #504

merged 1 commit into from
Dec 3, 2023

Conversation

TWiStErRob
Copy link
Contributor

@TWiStErRob TWiStErRob commented Dec 2, 2023

Is this line still relevant? When this line was added the project was using normal merges for PRs, now that they're being squashed to main, is there a reason to keep this line? (I was spending time making the commits really nice because I thought they'll be normal merged.)


Also, I recommend changing to this setting (regardless of this PR getting merged or not):
image
because the others bring in noise to the commits message and the default has inconsistent behavior between 1 commit and many commits. It might be set already.

@TimvdLippe
Copy link
Contributor

Indeed irrelevant, let's remove it

@TimvdLippe TimvdLippe merged commit 306dd3f into mockito:main Dec 3, 2023
4 checks passed
@TWiStErRob TWiStErRob deleted the patch-1 branch December 3, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants