Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setbfree to 0.8.10 #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented Dec 13, 2019

Hi,

Here is an update for setBfree. FIles from lv2 data should not be needed anymore.

Files looks to be well generated, but when I deployed them to ModDuoX, i don't have the expected rendering for synth and whirl, while the overdrive and reverb are fine.

If i reach back the files and check the rendering with modsdk it's fine.

If somebody could have a look, or have an idea, it can be very useful.

@falkTX
Copy link
Member

falkTX commented Dec 13, 2019

Thanks a lot!

We want to keep the custom lv2-data stuff though, as that allows to easily modify the bundle contents without having to create a patch file.

@vallsv
Copy link
Contributor Author

vallsv commented Dec 13, 2019

On a side note, the problem with lv2-data instead of patches is that it overwrite the author content. It make the upgrade of the plugin really difficult, cause you don't know why this or that was overwritten, or if it is still needed.

With patches, at least you start from the content of the plugin at a date, and you can review each changes make by patches. And when things have to be updated you can clean up the list of patches, that's explicit.

@falkTX
Copy link
Member

falkTX commented Dec 13, 2019

It is a trade-of. When we initially created the repo, we needed to modify a lot of plugins data quickly; adding patches to many projects was too slow...
Sure it is a bother when an update is needed, but in the MOD context, updates have to be always done with care anyway.
Also, the lv2-data allows for non-developers to be able to modify text and resources, something that would be very difficult if a non-dev has to create patches just to change a few lines of text.

We will see about updating setbfree soon.

@vallsv
Copy link
Contributor Author

vallsv commented Dec 13, 2019

I feel like the ModDuo store cache for the web server and do not update it when i update my plugin manually. Maybe this PR is working well.

For example, i have updated many times the recipe, but not the plugin version, and maybe the version is used to avoid to update things on the device side?

Do you know if there is a way to force to clean up things? I use the webservice to deploy updated packages: ̀http://192.168.51.1/sdk/install as explained in the wiki.

@falkTX
Copy link
Member

falkTX commented Dec 13, 2019

I feel like the ModDuo store cache for the web server and do not update it when i update my plugin manually. Maybe this PR is working well.

For example, i have updated many times the recipe, but not the plugin version, and maybe the version is used to avoid to update things on the device side?

That is correct. Contents are cached based on version.
While developing, you want to disable browser cache (easily done in the browser dev tools)

@vallsv
Copy link
Contributor Author

vallsv commented Dec 13, 2019

Ah! Nice. Then it looks to work. Ctrl+Maj+R looks to be not enough. I have to upgrade my web skill...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants