Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path-dependent failures in assess-artifacts test #2849

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

adpaco-aws
Copy link
Contributor

Shorten the tables frames in the expected file for the cargo-kani/assess-artifacts test. Otherwise, the test will fail when running the regression suite in a shorter-than-usual directory path (e.g., /tmp/kani). Came across this problem this morning when preparing for the release.

Callouts

  • Could also remove the frames/lines altogether.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws marked this pull request as ready for review November 1, 2023 20:29
@adpaco-aws adpaco-aws requested a review from a team as a code owner November 1, 2023 20:29
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! 😆

@adpaco-aws adpaco-aws merged commit f22f885 into model-checking:main Nov 1, 2023
20 checks passed
jaisnan added a commit that referenced this pull request Nov 17, 2023
Upgrade version number to 0.41.0

The CHANGELOG changes are:

```
# What's Changed
* Fix setup for `aarch64-unknown-linux-gnu` platform by @adpaco-aws in #2864
* Do not override `std` library during playback by @celinval in #2852
* Fix docker build step in release workflow by @adpaco-aws in #2854
* Fix path-dependent failures in `assess-artifacts` test by @adpaco-aws in #2849
* Automatic toolchain upgrade to nightly-2023-11-11 by @github-actions in #2870

**Full Changelog**: kani-0.40.0...kani-0.41.0

### Breaking Changes

* Set minimum python to 3.7 in docker container and release action by @remi-delmas-3000 in #2879
* Delete `any_slice` which has been deprecated since Kani 0.38.0. by @zhassan-aws in #2860
```

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants