Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expect() does not take format strings #2865

Merged
merged 2 commits into from
Nov 8, 2023
Merged

expect() does not take format strings #2865

merged 2 commits into from
Nov 8, 2023

Conversation

matthiaskrgr
Copy link
Contributor

This would just print

Function `{func}` should've been declared before usage'

on panic, it just now occurred to me that func is supposed to be content of a var 😄

@matthiaskrgr matthiaskrgr requested a review from a team as a code owner November 7, 2023 23:42
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Nov 7, 2023
zhassan-aws
zhassan-aws approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @matthiaskrgr!

@matthiaskrgr matthiaskrgr mentioned this pull request Nov 7, 2023
Open
@zhassan-aws zhassan-aws merged commit 0bde3ea into model-checking:main Nov 8, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhassan-aws zhassan-aws zhassan-aws approved these changes

Assignees
No one assigned
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiaskrgr @zhassan-aws