Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puppeteer to version 22.0.0 #2647

Merged

Conversation

Sanderovich
Copy link

Updated Puppeteer to its latest major. See #2646 for more context

Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: 4cc9064

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@web/test-runner-puppeteer Minor
@web/test-runner-chrome Minor
@web/test-runner-junit-reporter Patch
@web/test-runner Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

package-lock.json Outdated Show resolved Hide resolved
@koddsson
Copy link
Contributor

I'd love to land this but we'd need to fix the npm registry bit.

@koddsson
Copy link
Contributor

I think this will fix the flakyness with CI so it would be great to land this.

cc/ puppeteer/puppeteer#11967

@Sanderovich
Copy link
Author

Sanderovich commented Feb 22, 2024

@koddsson Thanks for the review! I resolved your comments

@koddsson
Copy link
Contributor

@koddsson Thanks for the review! I resolved your comments

The package-lock.json was a bit messed up and I just pushed a commit that I think fixes it.

@Sanderovich Sanderovich force-pushed the update-puppeteer-dependencies branch 3 times, most recently from 843daa4 to 11a5cea Compare March 4, 2024 15:42
MIGRATION.md Outdated Show resolved Hide resolved
@Sanderovich Sanderovich force-pushed the update-puppeteer-dependencies branch from 11a5cea to 62ec016 Compare March 4, 2024 16:47
@bashmish
Copy link
Member

bashmish commented Mar 4, 2024

Just realised that we might have a bunch of docs referencing the devices, and turned out to be true. Can you please check and update those? I think this means not just removing, but changing the documentation to use new recommended imports from puppeteer.

@Sanderovich Sanderovich force-pushed the update-puppeteer-dependencies branch from 62ec016 to e5f0ee8 Compare March 5, 2024 14:00
@Sanderovich Sanderovich force-pushed the update-puppeteer-dependencies branch from e5f0ee8 to 25a8391 Compare March 5, 2024 14:09
@Sanderovich
Copy link
Author

@bashmish I updated the imports in the docs. Additionally, I see the playwright packages are also exporting a devices variable, but I kept those as is to keep the focus of the PR on updating Puppeteer.

'@web/test-runner-chrome': minor
'@web/dev-server-hmr': minor
'@web/browser-logs': minor
'@web/dev-server': minor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to bump only

'@web/test-runner-puppeteer': minor
'@web/test-runner-chrome': minor

?

other packages don't have changes in the API, you only updated the devDependencies

Copy link
Author

@Sanderovich Sanderovich Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updatet the changeset 😄

@bashmish
Copy link
Member

bashmish commented Mar 5, 2024

I think it's the very last comment about the versions you need to bump, then we can merge this
I wasn't sure what packages would be impacted by the devices change, so needed to see your last changes brefore bringing this up

@Sanderovich Sanderovich force-pushed the update-puppeteer-dependencies branch from 25a8391 to 4cc9064 Compare March 5, 2024 15:57
@bashmish bashmish merged commit 3504267 into modernweb-dev:master Mar 6, 2024
5 of 6 checks passed
@bashmish
Copy link
Member

bashmish commented Mar 6, 2024

@Sanderovich thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants