Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript & eslint settings and transpilled AddingButton component as example #327

Merged

Conversation

unvir
Copy link
Contributor

@unvir unvir commented Aug 2, 2020

Initial configuration typescript and eslint

src/Components/AddingButton/AddingButton.tsx Outdated Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
Copy link

@sorovlad sorovlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Осталось сделать, чтобы линт прошел и будет идеально.

.creevey/SCREENSHOT_TESTS.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@sorovlad sorovlad merged commit b093fe8 into moira-alert:feature/typescript Aug 4, 2020
sorovlad pushed a commit that referenced this pull request Aug 10, 2020
…#327)

* AddingButton converted,
added ts supporting to webpack
added ts supporting to eslint

* Updated less-module import
sorovlad pushed a commit that referenced this pull request Aug 20, 2020
…330)

* Typescript and eslint settings and transpilled AddingButton component (#327)

* AddingButton converted,
added ts supporting to webpack
added ts supporting to eslint

* Updated less-module import

* Moved Api,Domain,helpers,logic from flow to ts

* Moved Api,Domain,helpers,logic from flow to ts

* Implemented review: renamed interface, removed autoupdate on dependencies

* Added todo, es2015
sorovlad pushed a commit that referenced this pull request Aug 20, 2020
…#327)

* AddingButton converted,
added ts supporting to webpack
added ts supporting to eslint

* Updated less-module import
sorovlad pushed a commit that referenced this pull request Aug 20, 2020
…330)

* Typescript and eslint settings and transpilled AddingButton component (#327)

* AddingButton converted,
added ts supporting to webpack
added ts supporting to eslint

* Updated less-module import

* Moved Api,Domain,helpers,logic from flow to ts

* Moved Api,Domain,helpers,logic from flow to ts

* Implemented review: renamed interface, removed autoupdate on dependencies

* Added todo, es2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants