-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript & eslint settings and transpilled AddingButton component as example #327
Merged
sorovlad
merged 7 commits into
moira-alert:feature/typescript
from
unvir:task/transpile_AddingButton
Aug 4, 2020
Merged
Typescript & eslint settings and transpilled AddingButton component as example #327
sorovlad
merged 7 commits into
moira-alert:feature/typescript
from
unvir:task/transpile_AddingButton
Aug 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added ts supporting to webpack added ts supporting to eslint
sorovlad
suggested changes
Aug 3, 2020
sorovlad
reviewed
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Осталось сделать, чтобы линт прошел и будет идеально.
sorovlad
pushed a commit
that referenced
this pull request
Aug 10, 2020
…#327) * AddingButton converted, added ts supporting to webpack added ts supporting to eslint * Updated less-module import
sorovlad
pushed a commit
that referenced
this pull request
Aug 20, 2020
…330) * Typescript and eslint settings and transpilled AddingButton component (#327) * AddingButton converted, added ts supporting to webpack added ts supporting to eslint * Updated less-module import * Moved Api,Domain,helpers,logic from flow to ts * Moved Api,Domain,helpers,logic from flow to ts * Implemented review: renamed interface, removed autoupdate on dependencies * Added todo, es2015
sorovlad
pushed a commit
that referenced
this pull request
Aug 20, 2020
…#327) * AddingButton converted, added ts supporting to webpack added ts supporting to eslint * Updated less-module import
sorovlad
pushed a commit
that referenced
this pull request
Aug 20, 2020
…330) * Typescript and eslint settings and transpilled AddingButton component (#327) * AddingButton converted, added ts supporting to webpack added ts supporting to eslint * Updated less-module import * Moved Api,Domain,helpers,logic from flow to ts * Moved Api,Domain,helpers,logic from flow to ts * Implemented review: renamed interface, removed autoupdate on dependencies * Added todo, es2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial configuration typescript and eslint