Tests: Initial e2e tests setup #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "Add trigger" test Add "Navigate to Add trigger page" test
sorovlad
changed the title
sorovlad
changed the title
sashasushko
approved these changes
Aug 14, 2020
| @@ -18,7 +18,7 @@ export default function NewTagBadge(props: Props): React.Node { | |||
| return ( | |||
| <div className={cn({ tag: true, removeable: onRemove, focused: focus })}> | |||
| {onClick ? ( | |||
| <button type="button" onClick={onClick} className={cn("title", "clickable")}> | |||
| <button type="button" onClick={onClick} className={cn("title", "clickable")} data-tid="New Tag"> | |||
There was a problem hiding this comment.
Why not/
Код выглядит немного чище, чем с разделителем дефисом.
Но это вскусовщина. Если считаешь лучше другая нотация, не проблема поменять.
sorovlad
changed the title
sashasushko
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration for start e2e tests on local console, editors or travise CI.
Added command
yarn test:e2eto run this tests.Added two examples "add trigger" and "navigate to add trigger's page".
Description:
Check users' scenarios use chromium and real API. This helps to check that front and api are working together correctly after updates.
To run locally, you need to install docker.
You don't need to start API and webpack-dev-server himself, jest runs them after lunch.