Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile and remove chr from CHROM #1

Merged
merged 6 commits into from
Mar 16, 2022
Merged

Conversation

aledj2
Copy link
Contributor

@aledj2 aledj2 commented Apr 1, 2021

This change is Reviewable

@aledj2 aledj2 requested a review from preciserobot April 1, 2021 11:57
@aledj2 aledj2 marked this pull request as draft April 1, 2021 12:25
Copy link
Contributor

@preciserobot preciserobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aledj2)


fh.py, line 138 at r1 (raw file):

record.CHROM.replace("chr","")

Safer to use

re.sub("^chr","",record.CHROM)

@aledj2 aledj2 marked this pull request as ready for review May 26, 2021 10:02
Copy link
Contributor

@preciserobot preciserobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aledj2)

Copy link
Contributor Author

@aledj2 aledj2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @preciserobot)


fh.py, line 138 at r1 (raw file):

Previously, preciserobot (David Brawand) wrote…
record.CHROM.replace("chr","")

Safer to use

re.sub("^chr","",record.CHROM)

Done.

Copy link
Contributor

@preciserobot preciserobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @preciserobot)

Copy link
Contributor

@preciserobot preciserobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aledj2)

@preciserobot preciserobot merged commit fd10edf into main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants