Release 5.0 #49
Release 5.0 #49
Conversation
…control` (fixes #28)
| @@ -43,22 +51,18 @@ module.exports = { | |||
| 'sibling', | |||
| 'index' | |||
| ], | |||
| 'newlines-between': 'never' | |||
| 'newlines-between': 'never', | |||
| alphabetize: {order: 'asc'} | |||
There was a problem hiding this comment.
The only downside here is currently this IMO: import-js/eslint-plugin-import#1378 (comment). However I think it's still better that this is taken care of automatically, than us trying to keep the imports in order manually.
| }, | ||
| "peerDependencies": { | ||
| "eslint": "^7.0.0" |
There was a problem hiding this comment.
I'm really glad that all the peer dependencies are now gone.
| 'react-hooks' | ||
| ), | ||
| 'react-hooks', | ||
| 'sort-destructure-keys' |
There was a problem hiding this comment.
This was the last missing piece so that everything related to React props is sorted (JSX, prop types, prop destructuring). sort-keys from ESLint is a bit too aggressive IMO.
| @@ -0,0 +1,3 @@ | |||
| // This enables ESLint to use dependencies of this config | |||
| // (see https://github.com/eslint/eslint/issues/3458) | |||
| require('@rushstack/eslint-patch/modern-module-resolution'); | |||
There was a problem hiding this comment.
ESLint wants to handle this itself one day, but in the meantime there are some good guys from Microsoft providing a patch.
|
Great work - thanks for putting so much effort into it and resolve all issues |
See the changelog for detailed release notes.
Fixes #12
Fixes #13
Fixes #27
Fixes #28
Fixes #29
Fixes #30
Fixes #31
Fixes #43
Fixes #42
Fixes #44
Fixes #46
Fixes #48
--> i.e. all open issues in this repository 🙂
I've tested this config in one of the latest setlist repos (plain JavaScript/React) and it has worked fine. I want to test it in another repository with TypeScript though before merging.