Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split data and code #144

Merged
merged 14 commits into from
Aug 16, 2024
Merged

Split data and code #144

merged 14 commits into from
Aug 16, 2024

Conversation

ielis
Copy link
Member

@ielis ielis commented Aug 15, 2024

Split the repository into data (this repository) and code (Phenopacket Store Toolkit).

From now on, we use phenopacket-store-toolkit for Q/C, release, and access. The toolkit is versioned separately from the store.

The toolkit can be installed from PyPi:

python3 -m pip install phenopacket-store-toolkit

Use to access Phenopacket Store

The toolkit dramatically simplifies loading phenopackets, e.g. SUOX cohort of Phenopacket Store 0.1.18:

from ppktstore.registry import configure_phenopacket_registry()

registry = configure_phenopacket_registry()
with registry.open_phenopacket_store(release="0.1.18") as ps:
    phenopackets = list(ps.iter_cohort_phenopackets("SUOX"))
assert len(phenopackets) == 35

The registry API is basically the same as HPO-toolkit's Ontology store.

Use for packaging and Q/C

For the release duties, the toolkit must be installed with a bunch of additional dependencies:

python3 -m pip install phenopacket-store-toolkit[release]

Then, the same CLI is available and we can use it to create the release ZIP and Q/C. The HOW_TO_RELEASE.md checklist has been updated.

@pnrobinson this will require an update on your machine(s). I'll help with the setup.

@ielis ielis changed the title Add Phenopacket Store registry, prepare for releasing on PyPi Split data and code Aug 16, 2024
@ielis ielis merged commit 95291c8 into main Aug 16, 2024
1 check passed
@ielis ielis deleted the prepare-for-publishing branch August 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant