Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running against Laravel 4.1 #60

Closed
abishekrsrikaanth opened this issue Oct 29, 2013 · 4 comments
Closed

Error when running against Laravel 4.1 #60

abishekrsrikaanth opened this issue Oct 29, 2013 · 4 comments

Comments

@abishekrsrikaanth
Copy link

I get the following error when running the library against Laravel 4.1

Declaration of Jenssegers\\Mongodb\\Builder::whereBetween() should 
be compatible with Illuminate\\Database\\Query\\Builder::whereBetween($column, 
array $values, $boolean = 'and', $not = false)
@abishekrsrikaanth
Copy link
Author

You will also need to fix composer.json on master to use the latest libraries for 4.1

 "illuminate/support": "4.x",
 "illuminate/database": "4.x",
 "illuminate/events": "4.x"

@abishekrsrikaanth
Copy link
Author

Sent a Pull Request for the same

@jenssegers
Copy link
Contributor

I don't know if I want to make this change at this moment. I prefer to follow the current stable Laravel release to prevent compatibility issues.

@abishekrsrikaanth
Copy link
Author

It kinda becomes difficult for people who want to use this library with Laravel 4.1.

You can probably merge the latest version on the develop branch and also make this change, so that developers can point to that to make use of the library.

Or may be there is another way to do this in composer it self, so that it doesn't affect Laravel 4.0 code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants