fix filtering with operator not like issue #1829
Conversation
|
@ahmedsayedabdelsalam, let's go to slack community, you can find link here. We have channel #review for communicating about PR's |
| $operator = '='; | ||
| // Replace like or not like with a Regex instance. | ||
| if (in_array($operator, ['like', 'not like'])) { | ||
| if (Str::startsWith($operator, 'not')) { |
There was a problem hiding this comment.
No need to do string operations here:
| if (Str::startsWith($operator, 'not')) { | |
| if ($operator === 'not like') { |
|
Any chance you could add a test as well? |
|
@Smolevich I think the issue is clear enough here to keep the discussion on github. I rather have discussions on Slack regarding difficult topics and see how others can help to collaborate. Moving the discussions away from github will only make it harder for people to know what's going on. |
There was a problem hiding this comment.
@Smolevich I think the issue is clear enough here to keep the discussion on github. I rather have discussions on Slack regarding difficult topics and see how others can help to collaborate.
Moving the discussions away from github will only make it harder for people to know what's going on.
Ok, I agree
| if ($operator == 'like') { | ||
| $operator = '='; | ||
| // Replace like or not like with a Regex instance. | ||
| if (in_array($operator, ['like', 'not like'])) { |
There was a problem hiding this comment.
Add additional test case for not like here please
There was a problem hiding this comment.
Any chance you could add a test as well?
I added the test case and replaced the string operation as suggested.
|
Good stuff! |
fix filtering with operator not like issue
when filtering data with not like operator like the following example
User::where('name', 'not like', 'ahmed')the following exception has been thrown
unknown operator: $not like
this PR fixes this issue and treated it as regex same as the like operator.