Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully convert monorepo to bzlmod #343

Open
Tracked by #345
leoluk opened this issue Aug 23, 2024 · 6 comments
Open
Tracked by #345

Fully convert monorepo to bzlmod #343

leoluk opened this issue Aug 23, 2024 · 6 comments
Assignees
@fionera
Labels
c/build enhancement New feature or request

Comments

@leoluk
Copy link
Member

leoluk commented Aug 23, 2024 •
edited
Loading

From what I understand about the design, this should allow us to depend on the monorepo from internal.git, while maintaining MVS semantics.

We should also set appropriate visibility rules to make sure we don't unintentionally expose APIs which we later regret.
@leoluk leoluk added enhancement New feature or request c/build labels Aug 23, 2024
@fionera
Copy link
Contributor

fionera commented Aug 26, 2024

This does add some workarounds for e.g. bazelbuild/bazel#19301

@fionera
Copy link
Contributor

fionera commented Aug 27, 2024

And to completely remove WORKSPACE we need to wait for rmohr/bazeldnf#60

@leoluk
Copy link
Member Author

leoluk commented Aug 27, 2024 •
edited
Loading

And to completely remove WORKSPACE we need to wait for rmohr/bazeldnf#60

Hmm, that's one more reason to attempt to switch to rules_nixpkgs

@leoluk
Copy link
Member Author

leoluk commented Aug 27, 2024

This does add some workarounds for e.g. bazelbuild/bazel#19301

Are we blocked on this?

@fionera
Copy link
Contributor

fionera commented Aug 27, 2024

This does add some workarounds for e.g. bazelbuild/bazel#19301

Are we blocked on this?

No we aren't. It's just not pretty :)

@leoluk leoluk mentioned this issue Sep 3, 2024
Open
monogon-bot pushed a commit that referenced this issue Sep 10, 2024
@fionera
treewide: migrate more to bzlmod
e1420ab 
This does migrate nearly everything to bzlmod and away from the "old"
WORKSPACE system. We do have to use some workarounds and there is no
good way to get the path to a repository. This definitively requires
some more love in future CLs but this should cover the basics. See
#343 for more information.

Change-Id: I0e188d8708b66fcdbdf0adc9143c93160e3395ae
Reviewed-on: https://review.monogon.dev/c/monogon/+/3357
Reviewed-by: Lorenz Brun <lorenz@monogon.tech>
Reviewed-by: Leopold Schabel <leo@monogon.tech>
Tested-by: Jenkins CI
@leoluk
Copy link
Member Author

leoluk commented Sep 24, 2024

Final piece is figuring out how to replace the hardcoded external repository names (which isn't technically necessary, but Bazel doesn't consider them stable and will change them soon).

@monogon-dev monogon-dev deleted a comment from 1sopropanol Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fionera fionera

Labels
c/build enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leoluk @fionera