Add coverage info (and related Sniff) #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just define the paths we are interested one and enable the text-coverage option in CI tools (travis and gha). Enable text-coverage to Everything not included are: - External libraries (PHPCompatibility, phpcs...). - Tests. - Frontend/CLI scripts.
Mostly used by coverage info anon classes, but there may be other cases, that sort of construction is allowed to have an inline phpdoc block. Covered with tests.
sarjona
approved these changes
Apr 22, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes 2 commits:
Add the
coverage.phpfile for the plugin, so when running with coverage enabled we get info about the files we are interested (keeping apart things like PHPCompatibilty, PHP_CodeSniffer... that are not ours).Add a new sniff that supports the "return new class extends..." anonymous classes.
Important note: This will be failing a number of the checks, because
moodle-plugin-ci( that is in charge of checking this) still doesn't know about the newmoodlecheckandcodecheckerimprovements, namely:That's pretty much the reason we want to release a new
moodle-plugin-civersion this week, to get all those improvements incorporated.But if you run codechecker and moodlecheck locally (or via CiBoT)... they all pass: