Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump highest php version to 8.0 for 311 and master #145

Merged
merged 1 commit into from
May 14, 2021

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented May 8, 2021

With core CI tests already passing for PHP 80 (see the php80 epic ), it's time to try it with codechecker.

So, bumping the highest runs of 311 and master from php74 to php80.

Let's see how it goes and if we need to perform any other change...

@stronk7
Copy link
Member Author

stronk7 commented May 8, 2021

Have created moodlehq/moodle-plugin-ci#94 because it seems that moodle-plugin-ci needs some love before plugins can run php80 tests.

@stronk7 stronk7 force-pushed the ci_php80 branch 7 times, most recently from 7fa5504 to 20b0f09 Compare May 14, 2021 15:32
Only real required change  is to set the new
max_input_vars=5000 requirement. Strictly speaking
only needed for php8, but it doesn't hurt with
older php versions and older moodle branches, so
setting it up always.

About the xmlrpc-beta extension, it's only needed
for php8 runs and only if the plugin uses xmlrpc
for something. If not, it can be omitted without
problem, as far as it's not a moodle requirement
but only a recommendation.

Finally, note that we keep behat & phpunit init and run
disabled, because there are some PHP 8 Warnings that
need to be fixed (see MDL-71622) before enabling them back.

For some reason GHA isn't able to detect those warnings and
everything is passing here, so we continue covered.
@stronk7
Copy link
Member Author

stronk7 commented May 14, 2021

    Bump highest php version to 8.0 for 311 and master
    
    Only real required change  is to set the new
    max_input_vars=5000 requirement. Strictly speaking
    only needed for php8, but it doesn't hurt with
    older php versions and older moodle branches, so
    setting it up always.
    
    About the xmlrpc-beta extension, it's only needed
    for php8 runs and only if the plugin uses xmlrpc
    for something. If not, it can be omitted without
    problem, as far as it's not a moodle requirement
    but only a recommendation.
    
    Finally, note that we keep behat & phpunit init and run
    disabled, because there are some PHP 8 Warnings that
    need to be fixed (see MDL-71622) before enabling them back.
    
    For some reason GHA isn't able to detect those warnings and
    everything is passing here, so we continue covered.

@stronk7 stronk7 merged commit de4cecd into moodlehq:master May 14, 2021
@stronk7
Copy link
Member Author

stronk7 commented May 14, 2021

Self-merging to be back to green and have php 8 covered with GHA and (partially) Travis.

@stronk7 stronk7 deleted the ci_php80 branch May 14, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant