New moodle.PHPUnit.TestCaseNames Sniff #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sniff in charge of verifying various things related with PHPUnit test cases names (files and classes and namespaces). Like: - Error: _test.php files missing any valid test case. - Error: incorrectly names test cases (not ended with _test[case] - Warning: test case classes not matching test case file names. - Error: found duplicate test case names. - Error: found test case name proposed for another test case. - Error: test case namespace not matching expected component namespace. - Warning: test case namespace missing, suggesting a correct one. - Error: found duplicate proposed test case names. - Error: found proposed test case name existing for another test case. Practically covered with unit tests. And behat tests updated. Also included, small modification to local_codechecker_testcase base class that now, when an incorrect fixture file is passed, it fails with error (previously it was exiting silently and was hard to detect what was happening when a typo in the fixture name was used).
stronk7
changed the title
andrewnicols
approved these changes
Nov 29, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sniff in charge of verifying various things related with PHPUnit
test cases names (files and classes and namespaces). Like:
Practically covered with unit tests. And behat tests updated.
Also included, small modification to local_codechecker_testcase base
class that now, when an incorrect fixture file is passed, it fails
with error (previously it was exiting silently and was hard to
detect what was happening when a typo in the fixture name was used).