Verify that sub namespaces in test match the expected location #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added one more check to the unit tests naming sniff that now verify, for testcase clases, that they are in the expected subdirectory, following the general namespace rules for stuff under the "classes" directory. Note that we still aren't checking the correctness under "classes" and, once that's implemented, surely some code here will be moved to the general namespaces sniff (a note about that has been added to code). Also, note that we aren't still checking for level2 correctness, that must be a valid API or "local", whenever that's possible it will be checked. So, this only validates that the location (sub-directories) of the file matches the sub-namespaces of the class. Covered with tests.
stronk7
force-pushed
the
verify_level2_test_namespace
branch
from
eab590a
to
7f87301
Compare
rezaies
approved these changes
Dec 30, 2021
|
Thanks, @rezaies ! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one more check to the unit tests naming sniff that now
verify, for testcase classes, that they are in the expected
subdirectory, following the general namespace rules for stuff
under the "classes" directory.
Note that we still aren't checking the correctness under "classes"
and, once that's implemented, surely some code here will be moved
to the general namespaces sniff (a note about that has been added
to code).
Also, note that we aren't still checking for level2 correctness, that
must be a valid API or "local", whenever that's possible it will be
checked.
So, this only validates that the location (sub-directories) of the
file matches the sub-namespaces of the class.
Covered with tests.