Avoid comma-separated use statements to require MOODLE_INTERNAL #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No matter that comma-separated use statements are a violation of the coding style (see Namespaces section), they, for sure, don't constitute a side-effect at all, so the MOODLE_INTERNAL check should be immune to them. This fix just enables comma-separated to be properly processed, covered with tests. Fixes moodlehq#175
|
Self-merging to have this deployed @ CI ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No matter that comma-separated use statements are a violation of
the coding style (see Namespaces section), they, for sure, don't
constitute a side-effect at all, so the MOODLE_INTERNAL check
should be immune to them.
This fix just enables comma-separated to be properly processed,
covered with tests.
Fixes #175