Add a hand of missing codes that are mandatory in phpcs3 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stronk7
force-pushed
the
add_missing_codes
branch
from
fc5d914
to
1e9a440
Compare
stronk7
force-pushed
the
add_missing_codes
branch
from
1e9a440
to
aad98bc
Compare
|
Self-merging, it's passing. Nothing really changes (unless you include codes on report) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to say. In phpcs these are optional, but in phpcs3 they are mandatory. And also they help to find stuff easily when reported. So better have the detail ready for whenever migrating to phpcs3.