Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock the session before processing files #95

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Unlock the session before processing files #95

merged 1 commit into from
Nov 2, 2020

Conversation

vmdef
Copy link
Contributor

@vmdef vmdef commented Oct 28, 2020

There is no apparent reason to lock the session while processing the files, as no data needs to be persisted back to the session.

@sarjona sarjona self-requested a review November 2, 2020 15:02
sarjona
sarjona approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, Víctor. The change makes sense to me so I'm happy to merge it!

@sarjona sarjona merged commit 7883f9f into moodlehq:phpcs3 Nov 2, 2020
@stronk7
Copy link
Member

stronk7 commented Nov 2, 2020

yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarjona sarjona sarjona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmdef @stronk7 @sarjona