Use pcov => xdebug => phpdbg for phpunit code coverage #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scara
reviewed
May 1, 2022
stronk7
force-pushed
the
better_code_coverage
branch
2 times, most recently
from
fb69f86
to
5712b3b
Compare
|
Hi super @scara ! Are you going to complete the review of this issue? TIA and no worries if you cannot! Ciao :-) |
|
Ping! |
|
Hi @stronk7,
Will look in the next days, within the week. HTH, |
Awesome! TIA! |
scara
reviewed
Jun 12, 2022
Right now we are only using phpdbg for phpunit code coverage. And it's causing some problems with latest (8.0, 8.1) php versions. Also, since phpunit 8, its code coverage tool supports pcov, that is the lighter and better alternative. And then, xdebug running in coverage mode has become way better in recent versions. So, with this patch applied, moodle-plugin-ci will look for the "best" code coverage alternative (pcov => xdebug => phpdbg) in every run. This guarantees that existing automations, not having pcov or xdebug available will continue fall-backing to phpdbg. But if any of the 2 extensions are available, we'll be using them. No matter of the above (fully automatic), it's also possible to configure the desired code coverage tool with 3 new options, in case it's needed to force any: - coverage-pcov - coverage-xdebug - coverage-phpdbg Added support to the '--verbose' option to be passed to phpunit (useful to debug options or see details about skipped tests). Includes modifications to both GHA docs and template to show the new options. And, also, changes to own CI tests to have both pcov and xdebug used all the time.
stronk7
force-pushed
the
better_code_coverage
branch
from
5712b3b
to
a0bec99
Compare
|
I've commented in the 3 places now: travis.yml and .github/workflows/test.yml with the very same comment: Those are all the changes applied. Ciao :-) |
scara
approved these changes
Jun 14, 2022
|
Thanks, @scara . Going to merge this now! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are only using phpdbg for phpunit code coverage. And
it's causing some problems with latest (8.0, 8.1) php versions.
Also, since phpunit 8, its code coverage tool supports pcov, that
is the lighter and better alternative. And then, xdebug running
in coverage mode has become way better in recent versions.
So, with this patch applied, moodle-plugin-ci will look for the
"best" code coverage alternative (pcov => xdebug => phpdbg) in
every run.
This guarantees that existing automations, not having pcov or
xdebug available will continue fall-backing to phpdbg. But if
any of the 2 extensions are available, we'll be using them.
No matter of the above (fully automatic), it's also possible
to configure the desired code coverage tool with 3 new options,
in case it's needed to force any:
Added support to the '--verbose' option to be passed to phpunit
(useful to debug options or see details about skipped tests).
Includes modifications to both GHA docs and template to show the new options.
And, also, changes to own CI tests to have both pcov and xdebug used
all the time.