Raise PHP min requirements to 7.2 and update PHPUnit to 8.5 #97
Conversation
stronk7
changed the title
|
I totally agree regarding major version bump for release. Can you rebase it please @stronk7, so codefixer commit is not added. |
And, also, raising PHP requirement to 7.2 in general all branches since Moodle 3.4 can use that PHP version so it's quite generous, specially when a bunch of them (34, 35, 36, 37, 38) are completely out of support. It comes with some other products updated too, so fixing at the same time all the new psalm detections found within moodle-plugin-ci
They can be left as far as many are only deprecations, but better update all them to new counterparts towards easier future updates.
Also, bump to ubuntu-18.04, dist files already are recommending it, hence not change needed there, only own tests. This closes moodlehq#96.
|
Sure, now that #95 has been merged, going to rebuild this, pointing to the new incoming version... will comment once ready... |
|
Ok, I've been doing some more tests... and with a couple of issues fixed in codechecker/moodlecheck/ci... I think that we can make moodle-plugin-ci current v3 to run php8 tests... still testing... but just setting "max_input_vars=5000" may be enough. Of course, that doesn't enable own tests to pass with php8, for that we need this issue and surely others... But, I think that it's better to:
How does that sound? For now... I'm going to keep this on hold... and concentrate on verifying that a minor is enough (aka, point 1). So we can make a minor release providing that. |
👍 HTH, |
|
I'm going to close this in favour of #151, where the new moodle-plugin-ci, with raised requirements, will be planned. |
This pull request updates PHPUnit (own tests) to version 8.5.x because it's the very first supporting PHP 8.
Also, explicitly we raise general requirements and declare PHP 7.0.x and 7.1.x unsupported. Both are very old PHP versions (EOL > 1y ago) and still, keeping support for PHP 7.2, all recent Moodle branches (34_STABLE and up) continue being supported by the tool (no matter that many of them (34, 35, 36, 36, 38) are out of support).
Still, if somebody needs a version of the tool working with PHP 7.0 or 7.1, they can continue using current
3.0.8without too much trouble, just they won't be able to add PHP 8.0 at the same time.Recommendation (to decide): Let's call to the next version
3.1.0or3.5.0or `4.0.0, given there are noticeable changes in the supported versions.Finally, a lot of components (composer) are updated with the bump of the min. PHP version, and some small adjustments have been applied to keep everything working. Plus all the PHPUnit 8.5 specific changes.
Another step towards PHP8 support happening @ #94