Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOBILE-4532 quiz: Update behat tests #3955

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marxjohnson
Copy link

MDL-68806 adds the new "Submitted" quiz attempt state, which means that once an attempt is submitted, grades will not be available until the ad-hoc tasks have run.

@NoelDeMartin NoelDeMartin self-requested a review March 5, 2024 12:45
Copy link
Contributor

@NoelDeMartin NoelDeMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found some things to improve, but overall the changes are good to go.

However, the CI won't pass until MDL-68806 is integrated in core, so we can't merge this until then. Once we resolve the changes I suggested, I can approve this and then we'll be able to merge it as soon as the core issue is integrated.

src/addons/mod/quiz/tests/behat/basic_usage.feature Outdated Show resolved Hide resolved
src/addons/mod/quiz/tests/behat/basic_usage.feature Outdated Show resolved Hide resolved
src/addons/mod/quiz/tests/behat/basic_usage.feature Outdated Show resolved Hide resolved
MDL-68806 adds the new "Submitted" quiz attempt state, which means that
once an attempt is submitted, grades will not be available until the
ad-hoc tasks have run.
@marxjohnson
Copy link
Author

Thanks for the pointers @NoelDeMartin, and for providing that updated snapshot. I have pushed an updated branch with those changes.

Copy link
Contributor

@NoelDeMartin NoelDeMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marxjohnson, I think this could be merged now but as I mentioned we need to wait until MDL-68806 is integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants