Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More reliable docker image check #2403

Merged
merged 1 commit into from
Jul 20, 2023
Merged

More reliable docker image check #2403

merged 1 commit into from
Jul 20, 2023

Conversation

crystalin
Copy link
Collaborator

According to docker/buildx#1509 (comment), using docker buildx imagetools inspect --raw is recommanded over docker manifest inspect

cc @girazoki for visibility

@crystalin crystalin added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels Jul 19, 2023
@crystalin crystalin requested a review from girazoki July 19, 2023 21:38
@github-actions
Copy link
Contributor

Coverage generated "Wed Jul 19 22:40:33 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2403/html/index.html

Master coverage: 87.40%
Pull coverage: 87.40%

@crystalin crystalin merged commit ee07d2a into master Jul 20, 2023
32 of 33 checks passed
@crystalin crystalin deleted the crystalin-better-docker-check branch July 20, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agusrodri Agusrodri Agusrodri approved these changes

@girazoki girazoki Awaiting requested review from girazoki

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crystalin @Agusrodri