-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock relay block number in dev service. #453
Mock relay block number in dev service. #453
Conversation
Co-authored-by: Alan Sapede <alan.sapede@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
It would be good to have an integration test for this too. From typescript we should ensure that para block 1 has relay block 1000 and that parablock 2 has relay block 1002. |
@JoshOrndorff Sounds good but that would mean using polkadot-launch right? |
This PR is all about the dev service, so no need to launch a parachain. |
Currently the dev service always injects the relay chain block number of 0. This is fine for many purposes, but the more our para logic depends on the relay block number the less suitable this becomes.
We now have at least three concrete cases that could benefit from a more realistically-mocked block number.
Checklist