Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify subscribe / annouce interaction #525
Clarify subscribe / annouce interaction #525
Changes from 10 commits
ef4e97b
b9eb195
983221b
bae358d
9975e17
bc2bbd5
d566967
f48aadd
206a023
155cc70
edde941
5964caa
252c203
e7b3cc5
2dbe780
1e960a9
bd7003c
4e3a0d4
837408d
365fb5a
92da76a
9a33793
e7612b9
50e5abd
a8ca0c1
4484de4
a4303a2
d28baa5
790c700
263c6d1
5de4ee8
2c5397e
08b9e0e
8c8875a
6e84e0a
38e0456
2cc1034
5be3af3
9708a36
f15edfa
24c43db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, what is the appropriate response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can relays limit the number of publishers for a given namespace? It seems like for DoS reasons they can. Maybe we should specify a minimum: "Relays MUST support at least X publishers announcing the same namespace"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well ... I suspect this is going to fall in policy for relays region. Lets say you have 10 million viewers of a Taylor Swift livestream that can all publish text comments to various chat tracks. You OK with the number of max publishers on the same namespace being in the millions ? It seems that different relays will want very different limits here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping SUBSCRIBE_NAMESPACE would solve some of that problem -- all 10M viewers have their own namespace
tswift/chat/unique_id
. We may need to indicate here what limits are likely to exist, because it influences how higher level protocols will use moqt in terms of namespace and track naming.Agreed the max will be different, but is there a min that we need to specify to get basic interop, eg: for make-before-break, min=2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR: Now that I'm understanding ANNOUNCE more, OK and CANCEL feel odd. Routing protocols are normally ANNOUNCE/UNANNOUNCE and that's it. I'm unsure what one does with ANNOUNCE_OK and ANNOUNCE_CANCEL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got no idea :-) We need an error to ANNOUNCE for auth errors, so it makes sense to have an OK just to know there was no error. But I have no idea why we need CANCEL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ANNOUNCE_CANCEL is used in the below flow IIYC
Existing subscriptions will still get served, but new subscriptions will not be sent to the publisher anymore.