Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed message queue clearance logic in ec.message.clearAll() method #631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dixitdeepak
Copy link
Contributor

The ec.message.clearAll() method is intended to clear all messages from the queue, but due to the current implementation, it fails to do so.

The method operates by first clearing the message list and then calling the clearErrors() method.
The clearErrors() method is designed to clear error messages from the queue, but as part of its operation, it inadvertently adds an error message back into the messageList.

This behavior results in the clearAll method being unable to fully clear the message queue, as error messages get reintroduced after the attempt to clear them.

@dixitdeepak
Copy link
Contributor Author

Alternatively we can clear the errorList and validationErrorList list in clearAll(),
and set the hasErrors = false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant