i18n improvements #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several suggestions for improved use of formatting functions, context and notices for translators. For reference see http://wceu2013.ottopress.com/ (once it’s back in place). Key points: 1. **Deliver complete messages.** Splitting text strings in translatable substrings bears the premise those chunks could be used in other languages as they can in English. They often cannot. 2. **Use formatting functions mainly to keep HTML out of translatable strings.** Security and all. _s needs to work on that, too, in places. 3. **Use [Codestyling Localization](https://wordpress.org/plugins/codestyling-localization/) to verify translatability of your code and language files.** It supports context functions as well as translators notices and will notify you in case multiple textdomains can be found in your code (my-simone, twentyfourteen etc). Also nb.po does not seem to be a valid language file name. It probably should be nb_NO.po, accompanied by a .mo file. Neat theme otherwise! Will provide German translation once this pull request has been accepted.
mor10
added a commit
that referenced
this pull request
Jul 14, 2014
i18n improvements courtesy of @glueckpress. Merged without alterations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Notes from this commit:)
Several suggestions for improved use of formatting functions, context and notices for translators. For reference see http://wceu2013.ottopress.com/ (once it’s back in place).
Key points:
.mo file.
Neat theme otherwise! Will provide German translation once this pull request has been accepted.