Fix the rendering of the different separators we've in the UI #18761
Conversation
|
Before the patch: |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2d3cc2f33e09aa1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2d3cc2f33e09aa1/output.txt Total script time: 1.01 mins Published |
|
@Snuffleupagus, out of curiosity, do you observe the same kind of differences before/after ? |
Currently, the css for a separator is something like { height: 1px; background-color: ... }.
But its rendering depends on its position on the screen.
So instead of setting the height to 1px, we just set something like { border-top: 1px solid ...; },
this way the final rendering is exactly the same for all the separators.
calixteman
force-pushed
the
fix_separator_color
branch
from
1bb4dc0
to
b29278e
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/76db42fff0d82dd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/76db42fff0d82dd/output.txt Total script time: 1.02 mins Published |
There was a problem hiding this comment.
I've compared https://mozilla.github.io/pdf.js/web/viewer.html and #18761 (comment) side-by-side, and everything looks identical to my eye.
r=me, thank you.
Currently, the css for a separator is something like { height: 1px; background-color: ... }. But its rendering depends on its position on the screen.
So instead of setting the height to 1px, we just set something like { border-top: 1px solid ...; }, this way the final rendering is exactly the same for all the separators.