Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #427: Migrate schedule_until into new json schedule field. #591

Closed
wants to merge 32 commits into from
Closed

Closes #427: Migrate schedule_until into new json schedule field. #591

wants to merge 32 commits into from

Conversation

emtwo
Copy link

@emtwo emtwo commented Oct 10, 2018

This migration should be applied after this PR lands upstream: getredash#2426 and is merged into our fork.

@emtwo emtwo self-assigned this Oct 10, 2018
@emtwo emtwo added the blocked label Oct 10, 2018
Allen Short and others added 27 commits December 17, 2018 13:20
@jezdez
In docker-entrypoint ensure tables exist
a33e479
@alison985 @jezdez
upgrade node and npm in dockerfile
0bd626d
@robotblake @jezdez
Update Circle CI for our workflow
18695a9 
- Use new master / rc release release strategy (#440)
- Migrate Circle CI 2.0 (#488, #502)
@jezdez
Pin PyAthena dependency to 1.2.0.
86f5c2f
@jezdez
Switch to PyMySQL for MySQL 5.7 support
1fc3098
@jezdez
Don't execute query when changing data sources (fixes #29)
57f11a7
@jezdez
Add schedule_until field to queries, to allow expiry (re #15)
6fd67ed
@spasovski @jezdez
Add compare query version support (re #7)
dd470bf
@jezdez
Filter tables from schema browser (re #31)
bc78aa5
@alison985 @jezdez
give warning/error msg on inaccurate graph config (re #57)
42688c2 
I tried to make
`JSON.stringify(this.visualization.options.columnMapping)` a variable
to avoid repeating it, but if I make it a `let` the linter throws an
error and if I make it a `const` then it doesn’t change with the UI and
the logic doesn’t work. :(

updated based on PR comments
@alison985 @jezdez
Add column type info to query runners (re #152, #23)
424b9f8
@alison985 @jezdez
Add last_active_at column to users page (re #155)
25a5f94
@jezdez
Add partition key marker to Athena and Presto columns (re #185)
d8c8eea
@jezdez
Run queries with no cached result in public dashboards (re #220)
894128d
@jezdez
secure cookies, add X-Content-Type-Options header (bug 1371613)
2e4a17d
@jezdez
Merge mozilla schema updates with schema from master
7327d9e
@jezdez
merge upstream db changes
b0c5bd6
@jezdez
properly rollback failed db commits
bf9a553
@jezdez
Install redash-stmo.
84e6973 
In the long run we'll be able to install additional dependencies by
having an own Dockerfile to build images based on the Redash image
but that installs additional Python dependencies. But until we have
a fork with lots of changes ourselves we need to do it this way.

Redash-stmo contains the ability to hook up our own Dockerflow
library.

Refs #13
Refs #37
@jezdez
Extend the Remote User Auth backend with REMOTE_GROUPS ability (#311)
c266c95 
Extend the Remote User Auth backend with the ability to pass remote user groups via a configurable request header similar to the REMOTE_USER header.

Refs #37.

If enabled the feature allows checks the header value against a configured list of group names, including the ability to use UNIX shell-style wildcards.
@jezdez
Unique names for query parameters (re #164)
c9f672b
@jezdez
Aggregate query results (re #35) (#339)
3798b62
@jasonthomas @jezdez
Updates to docker-entrypoint for worker and scheduler (#364)
3e0e2c0 
* Use --max-tasks-per-child as per celery documentation

* Set --max-memory-per-child to 1/4th of total system memory

* Split exec command over multiple lines

* Fix memory variable typo
@jezdez
Closes #396: Integration with Flower.
ab309d6
@jezdez
merge upstream db changes
9bb44f0
@jezdez
Add data source health monitoring via an extension.
f205882 
Refs: #379, #415
@jezdez
Use production build of react when deployed (fixes #606)
37f8aab
jezdez and others added 3 commits December 17, 2018 13:20
@jezdez
Various merge fixes.
84f1d06
@jezdez
Enable documentation links and versions of data sources (re #6).
018172a 
Refs #537, #553.

Co-authored-by: Marina Samuel <msamuel@mozilla.com>
Co-authored-by: Allen Short <ashort@mozilla.com>
Use entry_point.module_name instead of entry_point.name for looking u…
3eacea1 
…p the bundles.
@jezdez
Copy link

jezdez commented Jan 16, 2019

@emtwo Would you mind rebasing this, since that's the next step to close #427 after getredash#2426 got merged?

@emtwo
Copy link
Author

emtwo commented Jan 23, 2019

I've rebased this PR with 2 notes to make:

  • This is now based on the last upstream migration which returned the ability for the schedule field to be null: getredash@e8120c5#diff-ae8945bd01a33cb1ff4e201d68685558
  • I've removed references to schedule_until from models.py and serializers.py in this PR as well, but these may not be necessary depending on if it takes place when we pull in the latest upstream code.

@jezdez jezdez force-pushed the master branch 2 times, most recently from d575ecf to 6f4bfdb Compare January 25, 2019 09:47
@jezdez
Copy link

jezdez commented Feb 25, 2019

@emtwo I'm sorry but could you please do another rebase for this?

@jezdez jezdez added this to the 20 milestone Feb 25, 2019
@jezdez jezdez mentioned this pull request Mar 25, 2019
Merged
6 tasks
@jezdez
Copy link

jezdez commented Apr 3, 2019

This was ported into the master branch in 0deaf2f (via #922).

@jezdez jezdez closed this Apr 3, 2019
@jezdez jezdez removed the blocked label Apr 3, 2019
@jezdez jezdez deleted the emtwo/schedule_migration branch April 3, 2019 08:00
@MaxMood96 MaxMood96 mentioned this pull request Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emtwo emtwo

Labels
None yet
Projects
None yet
Milestone
20
Development

Successfully merging this pull request may close these issues.
6 participants
@emtwo @jezdez @alison985 @robotblake @spasovski @jasonthomas