Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -- on clang/clang-cl command-line #1983

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

glandium
Copy link
Collaborator

Fixes #1498

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 135 lines in your changes are missing coverage. Please review.

Comparison is base (68d0409) 30.69% compared to head (8aed3f0) 30.97%.

Files Patch % Lines
src/compiler/msvc.rs 39.28% 21 Missing and 47 partials ⚠️
src/compiler/gcc.rs 40.59% 6 Missing and 54 partials ⚠️
src/compiler/args.rs 57.14% 0 Missing and 6 partials ⚠️
src/compiler/c.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
+ Coverage   30.69%   30.97%   +0.27%     
==========================================
  Files          51       51              
  Lines       19192    19392     +200     
  Branches     9230     9330     +100     
==========================================
+ Hits         5891     6006     +115     
- Misses       7760     7763       +3     
- Partials     5541     5623      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit d3d5cbe into mozilla:main Nov 23, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sccache doesn't handle "--"
3 participants