Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when preprocessor cache cannot be used #2197

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

glandium
Copy link
Collaborator

@glandium glandium commented May 29, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 30.13%. Comparing base (0cc0c62) to head (02e4cb3).
Report is 47 commits behind head on main.

Files Patch % Lines
src/compiler/c.rs 0.00% 0 Missing and 5 partials ⚠️
src/compiler/gcc.rs 60.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
- Coverage   30.91%   30.13%   -0.79%     
==========================================
  Files          53       53              
  Lines       20112    20291     +179     
  Branches     9755     9742      -13     
==========================================
- Hits         6217     6114     -103     
- Misses       7922     8222     +300     
+ Partials     5973     5955      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre
Copy link
Collaborator

Needs rebase

@glandium
Copy link
Collaborator Author

glandium commented Jun 6, 2024

Needs rebase

that's because you merged #2195, which actually needed to be rebased on top of this one...

@glandium glandium changed the title Hook up too_hard_for_preprocessor_cache_mode Log when preprocessor cache cannot be used Jun 6, 2024
@sylvestre sylvestre merged commit 565a08b into mozilla:main Jun 6, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants