Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptographic backend isolation tests #109

Merged

Conversation

mattsb42-aws
Copy link
Contributor

As discussed in #108, this is the initial step in cryptographic backend isolation. This change adjusts the most test fixtures to use "whatever backend is available" and adds tox test environments that isolate the cryptographic backends to verify that all tests actually pass for all backends.

NOTE: As discussed in #108, some tests do fail as a result of this. Fixing that is the next step.

@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #109 into backend-explicit-tests will decrease coverage by 29.41%.
The diff coverage is 0%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           backend-explicit-tests    #109       +/-   ##
==========================================================
- Coverage                   94.61%   65.2%   -29.42%     
==========================================================
  Files                          13      13               
  Lines                        1003    1003               
==========================================================
- Hits                          949     654      -295     
- Misses                         54     349      +295
Impacted Files Coverage Δ
jose/backends/cryptography_backend.py 4.14% <0%> (-92.75%) ⬇️
jose/backends/rsa_backend.py 18.88% <0%> (-78.33%) ⬇️
jose/backends/pycrypto_backend.py 90.9% <0%> (-5.46%) ⬇️
jose/backends/__init__.py 54.54% <0%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c04ff...4d7b598. Read the comment docs.

@mattsb42-aws
Copy link
Contributor Author

Rebased on current master to ease merging down the road. @mpdavis, have you had a chance to look at this yet, as a starting point for the changes discussed in #108? Once this is in the new branch I can start picking off the gaps that it uncovered.

@mpdavis
Copy link
Owner

mpdavis commented Nov 9, 2018

lgtm

@mpdavis mpdavis merged commit b4d6ca2 into mpdavis:backend-explicit-tests Nov 9, 2018
@mattsb42-aws mattsb42-aws deleted the explicit-dependencies branch December 25, 2018 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants