[RSA] make backend-explicit tests use backend-explicit keys #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_pycrypto_RSA_key_instance and test_cryptography_RSA_key_instance both test compatibility of the backend-explicit RSAKey classes with the backend-native RSA key structures. As such, these tests must use the backend-explicit RSAKey classes rather than the default loaded from jose.backends to avoid breaking when multiple backends are present.
This was referenced Dec 25, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_pycrypto_RSA_key_instanceandtest_cryptography_RSA_key_instanceboth test compatibility of the backend-explicit RSAKey classes with the backend-native RSA key structures. As such, these tests must use the backend-explicit RSAKey classes rather than the default loaded from jose.backends to avoid breaking when multiple backends are present.NOTE: This fixes the
algorithms/test_RSA.py::test_cryptography_RSA_key_instancefailure in the compatibility test runs, but thebaseandcryptographyruns still fail and thecompatibilityrun still fails for the reason addressed in #115.