Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer cryptography over pycryptodome/pycrypto. #91

Closed
wants to merge 2 commits into from

Conversation

zejn
Copy link
Collaborator

@zejn zejn commented May 10, 2018

Fix issues such as #90.

@codecov-io
Copy link

codecov-io commented May 10, 2018

Codecov Report

Merging #91 into master will decrease coverage by 0.46%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   93.58%   93.12%   -0.47%     
==========================================
  Files          13       13              
  Lines         998     1003       +5     
==========================================
  Hits          934      934              
- Misses         64       69       +5
Impacted Files Coverage Δ
jose/jws.py 94.11% <ø> (ø) ⬆️
jose/backends/cryptography_backend.py 97.91% <100%> (+0.05%) ⬆️
jose/backends/__init__.py 36.36% <50%> (ø) ⬆️
jose/backends/pycrypto_backend.py 91.81% <0%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b6556...55aa99a. Read the comment docs.

@mattsb42-aws
Copy link
Contributor

Just adding a note for future reference: As discussed in #108, this is not really practical until the pyca/cryptography backend is fully functional (although once it is, I would love to see this change happen).

@mattsb42-aws
Copy link
Contributor

@zejn The core issue of this is now resolved with #129. There was also another change that you rolled into this; is that still needed?

@zejn
Copy link
Collaborator Author

zejn commented Apr 9, 2019

No, the other change was support for loading public keys from certificates, implemented with d3e6f73.

@zejn zejn closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants