Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Generator adds empty line if height option is not used in example #60

Closed
jussikinnula opened this issue Dec 31, 2018 · 1 comment
Closed

Generator adds empty line if height option is not used in example #60

jussikinnula opened this issue Dec 31, 2018 · 1 comment

Comments

@jussikinnula
Copy link
Contributor

Parser creates <example ...> ... </example> from the code parts in markdown files. If there's height option, the example contains also it. On generator, the example tag is changed to an iframe.

The problem is, if height is not set - iframe has an extra line break, which breaks some browsers.
@jussikinnula jussikinnula mentioned this issue Dec 31, 2018
Merged
mpetrovich pushed a commit that referenced this issue Jan 26, 2019
@jussikinnula @mpetrovich
Fix src/generator.js regex (#61)
3145bec 
This fixes issue #60
@mpetrovich
Copy link
Owner

Fixed in v3.1.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpetrovich @jussikinnula