Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vo_gpu: undeprecate --gamma-factor and --gamma-auto #14540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Akemi
Copy link
Member

@Akemi Akemi commented Jul 13, 2024

alternative to #14369

@Akemi Akemi changed the title vo_gpu: undeprecated --gamma-factor and --gamma-auto vo_gpu: undeprecate --gamma-factor and --gamma-auto Jul 13, 2024
Copy link

Download the artifacts for this pull request:

Windows
macOS

@guidocella
Copy link
Contributor

It was unclear to me too why these were deprecated. These will have to be added to gpu-next if undeprecated.

@Dudemanguy
Copy link
Member

--gamma-factor is trivial. not sure about --gamma-auto

@kasper93
Copy link
Contributor

These will have to be added to gpu-next if undeprecated.

/cc @haasn

@Akemi
Copy link
Member Author

Akemi commented Jul 15, 2024

maybe it would be better to make 'ambient lux' an observable property which can be changed by the backend, and whoever wants to do something with that value can do it with a script? the old assumption was this after all and is hardcoded:

1.0
    Pitch black or dimly lit room (default)
1.1
    Moderately lit room, home
1.2
    Brightly illuminated room, office

NOTE: This is based around the assumptions of typical movie content, which
contains an implicit end-to-end of about 0.8 from scene to display. For
bright environments it can be useful to cancel that out.

with an observable property the behaviour could be changed by the user to whatever they like.

Copy link
Member

@Dudemanguy Dudemanguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as is. I'll leave it up to you if you want to do anything more with --gamma-auto since it only works on macOS anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants