-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vo_gpu: undeprecate --gamma-factor and --gamma-auto #14540
base: master
Are you sure you want to change the base?
Conversation
Download the artifacts for this pull request: |
It was unclear to me too why these were deprecated. These will have to be added to gpu-next if undeprecated. |
--gamma-factor is trivial. not sure about --gamma-auto |
/cc @haasn |
maybe it would be better to make 'ambient lux' an observable property which can be changed by the backend, and whoever wants to do something with that value can do it with a script? the old assumption was this after all and is hardcoded:
with an observable property the behaviour could be changed by the user to whatever they like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine as is. I'll leave it up to you if you want to do anything more with --gamma-auto since it only works on macOS anyway.
alternative to #14369