-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FBXLoader.js bug and resolvement in v119 #19967
Comments
Thank you for pinging @Mugen87 and thank you for bringing attention to this @jimver04. I had tested the behavior of FBX and all of the other loaders involved in that PR, everything appeared normal. But it is possible I've missed something. I'll run a few tests to determine if we should revert those changes. |
@jimver04 Any chances to share your FBX file in this thread for testing? |
Send me your email: jimver04 at gmail.com |
Perhaps it is because I am using "Three.js" but not "Three.module.js" ??? |
fbx Exported as binary from Blender 2.83.2 but some parts of it are not mine and I can not share in the thread. I can send you via email : jimver04 at gmail.com |
It is a possibility, even though I remember testing the non-modular variant as well. I have reached you through email, you may remove your contact info if you wish to avoid spams and unwanted emails. |
I wasn't able to reproduce any problems on FBX/VTK/EXR loaders with either the modular or non-modular variants of the inflate/deflate libs. However I have an idea as to what could be your problem. FBXLoader specifically displays a warning when failing to locate the
However, since #19748, our inflate API has changed. Using the links lib version will no longer work properly. You must use three.js dev distribution version inflate.min.js. I believe this might solve your issue, but we could perhaps update these warnings in both FBX and EXR loaders just in case. ( or study different alternatives as discussed on the PR ) |
Sciecode I didn't find your email but you have right: I downloaded inflate.min.js from https://github.com/imaya/zlib.js/bin/ However, the version inside Three.js is the one that works with both "new Inflate" (also works with new Zlib.Inflate) So to conclude and close the issue: The warning at FBXLoader.js ~L3550 should be replaced as follows THREE.FBXLoader: External library Inflate.min.js required, obtain or import from https://github.com/imaya/zlib.js -> or make the change at FBXLoader.js L3554 , i.e. replace Inflate with Zlib.Inflate |
examples/js/loaders/FBXLoader.js L3554
var inflate = new Inflate( new Uint8Array( reader.getArrayBuffer( compressedLength ) ) );
->
var inflate = new Zlib.Inflate( new Uint8Array( reader.getArrayBuffer( compressedLength ) ) );
Otherwise Inflate can not be found.
jimver
The text was updated successfully, but these errors were encountered: