Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HLG materialization and processing into a shared utility #6

Open
wants to merge 2 commits into
base: nuke-hlg
Choose a base branch
from

Conversation

rjzamora
Copy link

@rjzamora rjzamora commented Aug 26, 2022

Uses "update-graph" instead of "update-graph-hlg" when the "distributed.scheduler.pickle" config is False. This just runs the same graph materialization and processing code on client instead of on the scheduler.

Note that we may want to use a config option that is distinct from scheduler/pickle, since the real decision is whether to materialize the graph on the client or scheduler.

@mrocklin - I know you didn't plan to support the "non-pickle" code path. However, this seems like a relatively simple escape hatch to support for now? Let me know what you think.

@rjzamora
Copy link
Author

@mrocklin - Let me know if you still wanted help here, or if you want to go in a different direction

@mrocklin
Copy link
Owner

Hey @rjzamora !

I still think that Nuking HLG serialization and embracing Pickle is probably the right move. I personally probably won't push on this (my dev time is low these days) but I think that it's something that @fjetter might be interested in. Can I interest you two in chatting directly sometime?

@mrocklin
Copy link
Owner

Florian and I were talking about this just yesterday in fact. I think that it might make sense to prioritize this somewhat soonish.

@rjzamora
Copy link
Author

Florian and I were talking about this just yesterday in fact. I think that it might make sense to prioritize this somewhat soonish.

Sounds good - Several of us at NVIDIA will be happy to collaborate on this effort :)

@mrocklin
Copy link
Owner

mrocklin commented Oct 28, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants