Fixed the bugs in Top Speaker Services #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ThusharaX
commented
Nov 29, 2021
ThusharaX
commented
- getTopSpeakers is fixed to prevent getting deleted soft data
- Removed async in then. from insertTopSpeaker, getTopSpeaker, getTopSpeakers
- Checked before assigning attributes in updateTopSpeaker
getTopSpeakers is fixed to prevent getting deleted soft data
Removed async in then. from insertTopSpeaker, getTopSpeaker, getTopSpeakers
Check before assigning attributes in updateTopSpeaker
|
CI/CD is failing. Please solve this |
getTopSpeakers is fixed to prevent getting deleted soft data
senuravihanjayadeva
previously approved these changes
Nov 30, 2021
rusiruavb
requested changes
Nov 30, 2021
if socialMediaURLs attribute is not availble handled
Changed the name topSpeaker to topSpeakers in getTopSpeakers
If topSpeaker deleted send a message to the controller. Message - Speaker is not found
senuravihanjayadeva
requested changes
Nov 30, 2021
senuravihanjayadeva
approved these changes
Nov 30, 2021
senuravihanjayadeva
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.