use full name, auth should not mutate request

mshustov · May 27, 2019 · 2517c97 · 2517c97
1 parent 52360f6
commit 2517c97
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/core/server/http/lifecycle/auth.ts b/src/core/server/http/lifecycle/auth.ts
@@ -95,7 +95,7 @@ const toolkit: AuthToolkit = {
 
 /** @public */
 export type AuthenticationHandler<T> = (
-  request: Request,
+  request: Readonly<Request>,
   sessionStorage: SessionStorage<T>,
   t: AuthToolkit
 ) => AuthResult | Promise<AuthResult>;

diff --git a/src/core/server/http/lifecycle/on_post_auth.ts b/src/core/server/http/lifecycle/on_post_auth.ts
@@ -88,7 +88,7 @@ export interface OnPostAuthToolkit {
 
 /** @public */
 export type OnPostAuthHandler<Params = any, Query = any, Body = any> = (
-  req: KibanaRequest<Params, Query, Body>,
+  request: KibanaRequest<Params, Query, Body>,
   t: OnPostAuthToolkit
 ) => OnPostAuthResult | Promise<OnPostAuthResult>;
 

diff --git a/src/core/server/http/lifecycle/on_pre_auth.ts b/src/core/server/http/lifecycle/on_pre_auth.ts
@@ -98,7 +98,7 @@ const toolkit: OnPreAuthToolkit = {
 
 /** @public */
 export type OnPreAuthHandler<Params = any, Query = any, Body = any> = (
-  req: KibanaRequest<Params, Query, Body>,
+  request: KibanaRequest<Params, Query, Body>,
   t: OnPreAuthToolkit
 ) => OnPreAuthResult | Promise<OnPreAuthResult>;