Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to fix options binding in .Net 7.0.1 #7

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

V1RuSyRa
Copy link
Contributor

There are some changes were made in .Net 7.0.1 to options with collections binding process and this fix is need to properly handle it.

There are some changes were made in .Net 7.0.1 to options with collections binding process and this fix is need to properly handle it.
…nding_fix

Changes to fix options binding in .Net 7.0.1
@msmolka
Copy link
Owner

msmolka commented Dec 22, 2022

I'm trying to find any issue with .net7 but cannot. I've updated projected to .net 7 and all tests are passing. Could you provide test case (e.g. add unit test) when this will fail?

@msmolka
Copy link
Owner

msmolka commented Dec 22, 2022

I've pushed new changes with .net 7. And no issue with tests

@V1RuSyRa
Copy link
Contributor Author

It fails on 2 of tests that you already have.
image

What version of SDK do you use? 7.0.100 or 7.0.101? On version 7.0.100 there are no problems, but on version 7.0.101 there are.

@msmolka
Copy link
Owner

msmolka commented Dec 22, 2022

Ok, this is strange in 7.0.0 and below it works. I believe it is bug in 7.0.1 and will raise it on .net hub. I will approve these changes as workaround

@msmolka msmolka merged commit 9bb2485 into msmolka:master Dec 22, 2022
@andyTheCoder
Copy link

Hi, any chance of creating a new nuget package containing this fix ?

@msmolka
Copy link
Owner

msmolka commented Jan 26, 2023

Hi, I've stopped releasing this, because this is bug in .NET Core 7.0.1 and 7.0.2 and already fixed in version 7.0.3
dotnet/runtime#80562
dotnet/runtime#79904

But maybe it would be good to do this.
Will try soon.

The bug is in Microsoft.Extensions.Configuration.Binder package
use version 7.0.0 or 7.0.3 and above

@msmolka
Copy link
Owner

msmolka commented Jan 26, 2023

Any way... I've pushed new nuget. Sorry for delay. I was hoping that .net core fix would be released earlier

@andyTheCoder
Copy link

Thank you very much for your swift response. 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants