fix: remove "NetworkError" in favor of "HttpResponse.error"

src/browser/setupWorker/start/createRequestListener.ts

@@ -7,7 +7,6 @@ import {
   ServiceWorkerMessage,
   WorkerChannel,
 } from './utils/createMessageChannel'
-import { NetworkError } from '~/core/NetworkError'
 import { parseWorkerRequest } from '../../utils/parseWorkerRequest'
 import { handleRequest } from '~/core/utils/handleRequest'
 import { RequiredDeep } from '~/core/typeUtils'
@@ -70,17 +69,6 @@ export const createRequestListener = (
         },
       )
     } catch (error) {
-      if (error instanceof NetworkError) {
-        // Treat emulated network error differently,
-        // as it is an intended exception in a request handler.
-        messageChannel.postMessage('NETWORK_ERROR', {
-          name: error.name,
-          message: error.message,
-        })
-
-        return
-      }
-
       if (error instanceof Error) {
         devUtils.error(
           `Uncaught exception in the request handler for "%s %s":

src/browser/setupWorker/start/utils/createMessageChannel.ts

@@ -17,7 +17,6 @@ interface WorkerChannelEventsMap {
     transfer?: [ReadableStream<Uint8Array>],
   ]
   NOT_FOUND: []
-  NETWORK_ERROR: [data: { name: string; message: string }]
 }
 
 export class WorkerChannel {

src/core/index.ts

@@ -46,7 +46,6 @@ export * from './HttpResponse'
 export * from './delay'
 export { bypass } from './bypass'
 export { passthrough } from './passthrough'
-export { NetworkError } from './NetworkError'
 
 // Validate environmental globals before executing any code.
 // This ensures that the library gives user-friendly errors

src/mockServiceWorker.js

@@ -112,15 +112,6 @@ self.addEventListener('fetch', function (event) {
 
   event.respondWith(
     handleRequest(event, requestId).catch((error) => {
-      if (error.name === 'NetworkError') {
-        console.warn(
-          '[MSW] Successfully emulated a network error for the "%s %s" request.',
-          request.method,
-          request.url,
-        )
-        return
-      }
-
       // At this point, any exception indicates an issue with the original request/response.
       console.error(
         `\
@@ -270,15 +261,6 @@ async function getResponse(event, client, requestId) {
     case 'MOCK_NOT_FOUND': {
       return passthrough()
     }
-
-    case 'NETWORK_ERROR': {
-      const { name, message } = clientMessage.data
-      const networkError = new Error(message)
-      networkError.name = name
-
-      // Rejecting a "respondWith" promise emulates a network error.
-      throw networkError
-    }
   }
 
   return passthrough()

test/browser/msw-api/res/network-error.mocks.ts

@@ -1,9 +1,9 @@
-import { http, NetworkError } from 'msw'
+import { http, HttpResponse } from 'msw'
 import { setupWorker } from 'msw/browser'
 
 const worker = setupWorker(
   http.get('/user', () => {
-    throw new NetworkError('Custom network error message')
+    return HttpResponse.error()
   }),
 )
 

test/browser/msw-api/setup-worker/scenarios/errors/network-error.mocks.ts

@@ -1,9 +1,9 @@
-import { http, NetworkError } from 'msw'
+import { http, HttpResponse } from 'msw'
 import { setupWorker } from 'msw/browser'
 
 const worker = setupWorker(
   http.get('/user', () => {
-    throw new NetworkError('Custom network error message')
+    return HttpResponse.error()
   }),
 )
 

test/browser/msw-api/setup-worker/scenarios/errors/network-error.test.ts

@@ -23,7 +23,6 @@ test('propagates a mocked network error', async ({
   spyOnConsole,
   fetch,
   page,
-  waitFor,
   makeUrl,
 }) => {
   const consoleSpy = spyOnConsole()
@@ -41,15 +40,6 @@ test('propagates a mocked network error', async ({
     ]),
   )
 
-  // Expect a notification warning from the library.
-  await waitFor(async () => {
-    expect(workerConsole.messages.get('warn')).toEqual(
-      expect.arrayContaining([
-        `[MSW] Successfully emulated a network error for the "GET ${endpointUrl}" request.`,
-      ]),
-    )
-  })
-
   // The worker must not produce any errors.
   expect(workerConsole.messages.get('error')).toBeUndefined()
 })

test/node/msw-api/res/network-error.node.test.ts

@@ -2,22 +2,23 @@
  * @jest-environment node
  */
 import fetch from 'node-fetch'
-import { http, NetworkError } from 'msw'
+import { http, HttpResponse } from 'msw'
 import { setupServer } from 'msw/node'
 
-const server = setupServer()
+const server = setupServer(
+  http.get('http://example.com/user', () => {
+    return HttpResponse.error()
+  }),
+)
 
 beforeAll(() => server.listen())
 afterAll(() => server.close())
 
 test('throws a network error when used with fetch', async () => {
-  server.use(
-    http.get('http://test.io/user', () => {
-      throw new NetworkError('Custom network error message')
-    }),
-  )
+  const res = await fetch('http://example.com/user')
+  console.log(res.ok, res.status, res.statusText, res.type)
 
-  await expect(fetch('http://test.io/user')).rejects.toThrow(
-    'Custom network error message',
+  await expect(fetch('http://example.com/user')).rejects.toThrow(
+    'Failed to fetch',
   )
 })