Skip to content

Commit

Permalink
test: use uuidv4 in tests for requestid
Browse files Browse the repository at this point in the history
  • Loading branch information
sam-kvale-sap committed Jan 15, 2024
1 parent 1ba5e9e commit c9d6bd8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
7 changes: 4 additions & 3 deletions src/core/handlers/GraphQLHandler.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
GraphQLResolverExtras,
isDocumentNode,
} from './GraphQLHandler'
import { uuidv4 } from '../utils/internal/uuidv4'
import { HttpResponse } from '../HttpResponse'
import { ResponseResolver } from './RequestHandler'

Expand Down Expand Up @@ -736,7 +737,7 @@ describe('run', () => {
userId: 'abc-123',
},
})
const requestId = 'requestId'
const requestId = uuidv4()
const result = await handler.run({ request, requestId })

expect(result!.handler).toEqual(handler)
Expand Down Expand Up @@ -778,7 +779,7 @@ describe('run', () => {
const request = createPostGraphQLRequest({
query: LOGIN,
})
const requestId = 'requestId'
const requestId = uuidv4()
const result = await handler.run({ request, requestId })

expect(result).toBeNull()
Expand Down Expand Up @@ -826,7 +827,7 @@ describe('request', () => {
`,
})

const requestId = 'requestId'
const requestId = uuidv4()
await handler.run({ request, requestId })

expect(matchAllResolver).toHaveBeenCalledTimes(1)
Expand Down
9 changes: 5 additions & 4 deletions src/core/handlers/HttpHandler.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* @vitest-environment jsdom
*/
import { uuidv4 } from '../utils/internal/uuidv4'
import { HttpHandler, HttpRequestResolverExtras } from './HttpHandler'
import { HttpResponse } from '..'
import { ResponseResolver } from './RequestHandler'
Expand Down Expand Up @@ -151,7 +152,7 @@ describe('run', () => {
test('returns a mocked response given a matching request', async () => {
const handler = new HttpHandler('GET', '/user/:userId', resolver)
const request = new Request(new URL('/user/abc-123', location.href))
const requestId = 'requestId'
const requestId = uuidv4()
const result = await handler.run({ request, requestId })

expect(result!.handler).toEqual(handler)
Expand All @@ -175,7 +176,7 @@ describe('run', () => {
const handler = new HttpHandler('POST', '/login', resolver)
const result = await handler.run({
request: new Request(new URL('/users', location.href)),
requestId: 'requestId',
requestId: uuidv4(),
})

expect(result).toBeNull()
Expand All @@ -185,7 +186,7 @@ describe('run', () => {
const handler = new HttpHandler('GET', '/users', resolver)
const result = await handler.run({
request: new Request(new URL('/users', location.href)),
requestId: 'requestId',
requestId: uuidv4(),
})

expect(result?.parsedResult?.match?.params).toEqual({})
Expand All @@ -206,7 +207,7 @@ describe('run', () => {
const run = async () => {
const result = await handler.run({
request: new Request(new URL('/users', location.href)),
requestId: 'requestId',
requestId: uuidv4(),
})
return result?.response?.text()
}
Expand Down

0 comments on commit c9d6bd8

Please sign in to comment.